RFR: 8183552: Move align functions to align.hpp

Stefan Karlsson stefan.karlsson at oracle.com
Wed Jul 5 06:35:22 UTC 2017


Hi Thomas,

On 2017-07-05 08:10, Thomas Stüfe wrote:
> Hi Stefan,
>
> this looks good. This change (and all the preceding ones) are nice 
> cleanups!

Thanks for the review!

StefanK

>
> Kind Regards, Thomas
>
>
>
> On Wed, Jul 5, 2017 at 12:25 AM, Stefan Karlsson 
> <stefan.karlsson at oracle.com <mailto:stefan.karlsson at oracle.com>> wrote:
>
>     Hi all,
>
>     Please review this patch to move the align functions to align.hpp.
>
>     http://cr.openjdk.java.net/~stefank/8183552/webrev.00
>     <http://cr.openjdk.java.net/%7Estefank/8183552/webrev.00>
>     https://bugs.openjdk.java.net/browse/JDK-8183552
>     <https://bugs.openjdk.java.net/browse/JDK-8183552>
>
>     The patch mainly moves the functions and adding #include
>     "utilities/align.hpp" lines, but it also moves ScaleForWordSize to
>     globals.hpp to prevent a cyclic dependency between align.hpp and
>     globalDefinitions.hpp.
>
>     Thanks,
>     StefanK
>
>



More information about the hotspot-dev mailing list