RFR (M): 8184334: Generalizing Atomic with templates

[Roman Kennke]

Hi Erik,

I like the stuff. Cannot find anything wrong in the patch (i.e. ok from
me as non-reviewer), but have some questions:
- Do you plan to fix+remove the now deprecated methods, e.g. store_ptr()
soon?
- Have you given any thought about C++11 atomics? I don't know if that
will ever be feasible, but part of me would find it nice to just use
that in the future? Or at least get/stay as close to it API-wise as
possible?

Roman

Am 17.07.2017 um 11:04 schrieb Erik Österlund:
> Hi Kim,
>
> Thank you for the review. I have now fixed all the issues you mentioned.
>
> New full webrev:
> http://cr.openjdk.java.net/~eosterlund/8184334/webrev.01/
>
> New incremental webrev:
> http://cr.openjdk.java.net/~eosterlund/8184334/webrev.00_01/
>
> Thanks,
> /Erik
>
> On 2017-07-14 20:56, Kim Barrett wrote:
>>> On Jul 14, 2017, at 12:28 PM, Erik Österlund
>>> <erik.osterlund at oracle.com> wrote:
>>>
>>> Hi,
>>>
>>> Bug:
>>> https://bugs.openjdk.java.net/browse/JDK-8184334
>>>
>>> Webrev:
>>> http://cr.openjdk.java.net/~eosterlund/8184334/webrev.00/
>> ------------------------------------------------------------------------------
>>
>> Another pre-review comment that seems to have been missed.  (Your
>> reply indicated the suggestion was accepted.)
>>
>> src/share/vm/runtime/atomic.hpp
>>   250   typedef typename IntegerTypes::Signed<intptr_t>::type Raw;
>> intptr_t => U*
>>
>>   269     typedef typename IntegerTypes::Signed<intptr_t>::type Raw;
>>   286     typedef typename IntegerTypes::Signed<intptr_t>::type Raw;
>> intptr_t => T*
>>
>> ------------------------------------------------------------------------------
>>
>>
>