RFR (S) 8184753: Asserts against MinObjectAlignment should avoid integer division

Thomas Schatzl thomas.schatzl at oracle.com
Tue Jul 18 09:05:50 UTC 2017


Hi Aleksey,

On Tue, 2017-07-18 at 10:41 +0200, Aleksey Shipilev wrote:
> On 07/18/2017 10:02 AM, Aleksey Shipilev wrote:
> > 
> > On 07/18/2017 09:58 AM, Mikael Gerdin wrote:
> > > 
> > > Hi Aleksey,
> > > 
> > > [...]
> > > But the is_object_aligned(size_t) function _is_ about object
> > > sizes, it just has a weird naming and a weird overload with the
> > > void* variant which asserts that a pointer is correctly aligned.
> > Ah, unfortunate naming indeed. Let me try to switch to
> > is_object_aligned.
> That seems to work well:
>   http://cr.openjdk.java.net/~shade/8184753/webrev.03/
>   http://cr.openjdk.java.net/~shade/8184753/hotspot.changeset
> 

  latest changeset seems good. Ship it.

Thomas



More information about the hotspot-dev mailing list