Request for review for JDK-8184045 - TestSystemGCWithG1.java times out on Solaris SPARC

[Daniel D. Daugherty]

On 7/20/17 11:28 AM, Alexander Harlap wrote:
> Hi Dan,
>
> Thank you for your review.
>
> I will remove erroneous extra import.
>
> Running jtreg test  TestSystemGCWithG1.java (outside of aurora) on 
> Solaris Sparc takes about 2900 sec (before change) and is twice faster 
> after change.
>
> With aurora it will be slower, but should be enough to eliminate timeout.

Thanks for the info.

All four variants are already run with:

     * @run main/othervm/timeout=300 ...

so they aren't run in parallel with anything else...
I think this is the best you can do...

Dan


>
> Alex
>
> On 7/20/2017 12:37 PM, Daniel D. Daugherty wrote:
>> On 7/20/17 9:31 AM, Alexander Harlap wrote:
>>> Please review changes forJDK-8184045 
>>> <https://bugs.openjdk.java.net/browse/JDK-8184045> - 
>>> TestSystemGCWithG1.java times out on Solaris SPARC (labeled as 
>>> integration blocker)
>>>
>>> Proposed change will avoid timeout failure for new stress tests 
>>> TestSystemGCWithG1.java, TestSystemGCWithCMS.java and 
>>> TestSystemGCWithSerial.java regularly observed on Solaris Sparc
>>>
>>> Change is located at 
>>> http://cr.openjdk.java.net/~aharlap/8184045/webrev.00/
>>
>> test/gc/stress/systemgc/TestSystemGC.java
>>     L32: import jdk.test.lib.Platform;
>>         Not sure why this was added.
>>
>>     (old) L187:         runAllPhases();
>>         So your theory is that calling runAllPhases() twice
>>         takes too much time on the Solaris SPARC machines.
>>
>>         What are the average times before and after making
>>         this change on Solaris SPARC?
>>
>> Thumbs up! Don't need to see a new webrev if you decide
>> to delete the new import.
>>
>> Dan
>>
>>>
>>>
>>> Alex
>>>
>>
>