Request for review for JDK-8184045 - TestSystemGCWithG1.java times out on Solaris SPARC

[Erik Helin]

On 07/21/2017 01:50 PM, Erik Helin wrote:
> On 07/20/2017 05:31 PM, Alexander Harlap wrote:
>> Please review changes forJDK-8184045
>> <https://bugs.openjdk.java.net/browse/JDK-8184045> -
>> TestSystemGCWithG1.java times out on Solaris SPARC (labeled  as
>> integration blocker)
>>
>> Proposed change will avoid timeout failure for new stress tests
>> TestSystemGCWithG1.java, TestSystemGCWithCMS.java and
>> TestSystemGCWithSerial.java regularly observed on Solaris Sparc
>>
>> Change is located at
>> http://cr.openjdk.java.net/~aharlap/8184045/webrev.00/
>
> Instead of removing the second pass, can you check if the args[0] ==
> "long"? The code can look like:
>
>   public static void main(String[] args) {
>       populateLongLived();
>       runAllPhases();
>       if (args.length > 0 && args[0] == "long") {

...aaaand as couple of my colleagues pointed out while smiling, you 
should of course write args[0].equals("long") :)

Thanks,
Erik

>           runAllPhases();
>       }
>   }
>
> This way the stress test can be used in "long" and "short" mode.
>
> Thanks,
> Erik
>
>> Alex
>>