RFR(xxs): 8185262: Keep default logging for Metaspace OOM short and concise

Ioi Lam ioi.lam at oracle.com
Tue Jul 25 17:12:35 UTC 2017


Hi Thomas,

how about switching lines 3739 and 3740?

3738     if (log.is_debug()) {
3739       LogStream ls(log.debug());
3740       if (loader_data->metaspace_or_null() != NULL) {
3741         loader_data->dump(&ls);
3742       }
3743     }

What kind of tests have you run?

Thanks
- Ioi

On 7/25/17 10:07 AM, Thomas Stüfe wrote:
> Hi all,
>
> may I have please reviews for this very tiny change:
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8185262
> webrev: http://cr.openjdk.java.net/~stuefe/webrevs/
> 8185262-keep-metaspace-oom-log-short-for-default/webrev.00/webrev/
>
> On Metaspace OOM, we dump all metaspace chunks in use. This can be very
> lengthy. It would be nice if this part of logging were restricted to a
> higher loglevel. In this change, I restrict it to debug.
>
> Kind Regards, Thomas



More information about the hotspot-dev mailing list