RFR: 8161145: The min/max macros make hotspot tests fail to build with GCC 6

[Erik Österlund]

Thank you.

/Erik

On 2017-06-01 13:17, Per Liden wrote:
> On 2017-06-01 12:34, Erik Österlund wrote:
>> Hi Per,
>>
>> On 2017-06-01 11:49, Per Liden wrote:
>>> Hi,
>>>
>>> On 2017-06-01 10:18, Kim Barrett wrote:
>>>>> On May 31, 2017, at 11:01 AM, Erik Österlund
>>>>> <erik.osterlund at oracle.com> wrote:
>>>>>
>>>>> Hi,
>>>>>
>>>>> Excellent. In that case I would like reviews on this patch that does
>>>>> exactly that:
>>>>> http://cr.openjdk.java.net/~eosterlund/8161145/webrev.00/
>>>
>>> Looks good, but can we please add a comment here describing why we're
>>> doing this. It's not obvious :)
>>
>> Thank you for the review. Here is a webrev with the added comment:
>> http://cr.openjdk.java.net/~eosterlund/8161145/webrev.01/
>
> Looks good, thanks!
>
> /Per
>
>>
>> Thanks,
>> /Erik
>>
>>>
>>>>>
>>>>> Testing: JPRT
>>>>>
>>>>> Need a sponsor.
>>>>
>>>> FWIW, another option would be to remove all the min/max stuff here,
>>>> and add -DNOMINMAX (or whatever the proper syntax is) in the Windows
>>>> build configuration.  I did some later research on JDK-8161145, and
>>>> defining that macro seems to be the "official" way to suppress those
>>>> macros in the offending windows header.
>>>
>>> We have a similar problem with min/max on Solaris, so it's not only a
>>> Windows issue. The approach Erik's patch takes seems more portable.
>>>
>>> cheers,
>>> Per
>>>
>>>>
>>>> The proposed change also seems fine to me, not surprisingly. Under the
>>>> circumstances, not sure I should be counted as a reviewer :)
>>>>
>>>> I can sponsor though.
>>>>
>>