RFR: 8161145: The min/max macros make hotspot tests fail to build with GCC 6

Erik Osterlund erik.osterlund at oracle.com
Thu Jun 1 16:44:06 UTC 2017


Thank you Andrew.

/Erik

> On 1 Jun 2017, at 18:25, Andrew Hughes <gnu.andrew at redhat.com> wrote:
> 
>> On 1 June 2017 at 12:17, Per Liden <per.liden at oracle.com> wrote:
>>> On 2017-06-01 12:34, Erik Österlund wrote:
>>> 
>>> Hi Per,
>>> 
>>>> On 2017-06-01 11:49, Per Liden wrote:
>>>> 
>>>> Hi,
>>>> 
>>>> On 2017-06-01 10:18, Kim Barrett wrote:
>>>>>> 
>>>>>> On May 31, 2017, at 11:01 AM, Erik Österlund
>>>>>> <erik.osterlund at oracle.com> wrote:
>>>>>> 
>>>>>> Hi,
>>>>>> 
>>>>>> Excellent. In that case I would like reviews on this patch that does
>>>>>> exactly that:
>>>>>> http://cr.openjdk.java.net/~eosterlund/8161145/webrev.00/
>>>> 
>>>> 
>>>> Looks good, but can we please add a comment here describing why we're
>>>> doing this. It's not obvious :)
>>> 
>>> 
>>> Thank you for the review. Here is a webrev with the added comment:
>>> http://cr.openjdk.java.net/~eosterlund/8161145/webrev.01/
>> 
>> 
>> Looks good, thanks!
>> 
>> /Per
>> 
> 
> Looks good to me too, and will be great to finally see this fixed.
> 
> It'll also need backporting to 9 now.
> 
> Thanks,
> -- 
> Andrew :)
> 
> Senior Free Java Software Engineer
> Red Hat, Inc. (http://www.redhat.com)
> 
> Web Site: http://fuseyism.com
> Twitter: https://twitter.com/gnu_andrew_java
> PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
> Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222



More information about the hotspot-dev mailing list