RFR(10)(S): 8181503: Can't compile hotspot with c++11

[Thomas Stüfe]

hi Kim,

On Tue, Jun 13, 2017 at 12:07 AM, Kim Barrett <kim.barrett at oracle.com>
wrote:

> > On Jun 12, 2017, at 10:29 AM, Gerard Ziemski <gerard.ziemski at oracle.com>
> wrote:
> >
> > hi all,
> >
> > Please review this small fix, which addresses 4 issues caught by c++11
> compiler on a Mac:
> >
> > […]
> > References:
> > bug link at https://bugs.openjdk.java.net/browse/JDK-8181503
> > webrev at http://cr.openjdk.java.net/~gziemski/8181503_rev1
> >
> > Tested with JPRT hotspot.
>
> <snip>
>


> Also, in chasing through some of this, I noticed
> os::Posix::is_valid_signal calls sigaddset with an uninitialized
> sigset_t (neither sigemptyset nor sigfillset has been applied). The
> documentation says the results are undefined if that initialization
> hasn't been done.
>
>
You are right, this is relying on undefined behavior. It never caused an
error, but still invalid. I opened a separate issue:
https://bugs.openjdk.java.net/browse/JDK-8182034

..Thomas



> ------------------------------------------------------------
> ------------------
>
> Other changes look good.
>
>