RFR(XL): 8181449: Fix debug.hpp / globalDefinitions.hpp dependency inversion

[Kim Barrett]

> On Jun 21, 2017, at 8:21 PM, Daniel D. Daugherty <daniel.daugherty at oracle.com> wrote:
> 
> On 6/16/17 6:33 PM, Kim Barrett wrote:
>> Please review this refactoring of debug.hpp and globalDefinitions.hpp
>> so that debug.hpp no longer includes globalDefinitions.hpp. […]
>> 
>> CR:
>> https://bugs.openjdk.java.net/browse/JDK-8181449
>> 
>> Testing:
>> jprt
>> 
>> Webrev:
>> http://cr.openjdk.java.net/~kbarrett/8181449/hotspot.00/
> 
> Normally, I would drop a list of the files here and hit them
> all one by one. That style's not going to work well with this
> review.

:)

>> (2) http://cr.openjdk.java.net/~kbarrett/8181449/move_format_buffer/
> 
> src/share/vm/utilities/formatBuffer.cpp
>    jcheck won't like the blank line at the end of the file.

Fixed.

>> (3) http://cr.openjdk.java.net/~kbarrett/8181449/move_pns/
> 
> src/share/vm/utilities/vmError.cpp
>    L210:   if (fr.pc()) {
>    L219:       if (t && t->is_Java_thread()) {
>        nit - uses implied boolean
>        (not your bug, you just moved the code).

There are quite a few more examples of implied booleans in this file.
I’d prefer to leave this alone for this changeset.

> Thumbs up! Very nice job of detangling…

Thanks.