RFR(XL): 8181917: Refactor UL LogStreams to avoid using resource area

[Erik Helin]

On 06/21/2017 06:16 PM, Thomas Stüfe wrote:
> New Webrev:
>  http://cr.openjdk.java.net/~stuefe/webrevs/8181917-refactor-ul-logstream/all.webrev.02/webrev/
>

Just a quick, very minor, nit (still reviewing it all):

--- old/src/share/vm/logging/log.hpp	2017-06-21 17:40:35.171829500 +0200
+++ new/src/share/vm/logging/log.hpp	2017-06-21 17:40:34.157130800 +0200
@@ -105,10 +105,6 @@
  //
  #define LogTarget(level, ...) LogTargetImpl<LogLevel::level, 
LOG_TAGS(__VA_ARGS__)>

-// Forward declaration to decouple this file from the outputStream API.
-class outputStream;
-outputStream* create_log_stream(LogLevelType level, LogTagSet* tagset);
-
  template <LogLevelType level, LogTagType T0, LogTagType T1, LogTagType 
T2, LogTagType T3, LogTagType T4, LogTagType GuardTag>
  class LogTargetImpl;

@@ -173,9 +169,6 @@
    static bool is_##name() { \
      return is_level(LogLevel::level); \
    } \
-  static outputStream* name##_stream() { \
-    return create_log_stream(LogLevel::level, &LogTagSetMapping<T0, T1, 
T2, T3, T4>::tagset()); \
-  } \
    static LogTargetImpl<LogLevel::level, T0, T1, T2, T3, T4, GuardTag>* 
name() { \
      return (LogTargetImpl<LogLevel::level, T0, T1, T2, T3, T4, 
GuardTag>*)NULL; \
    }
@@ -204,9 +197,8 @@
      va_end(args);
    }

-  static outputStream* stream() {
-    return create_log_stream(level, &LogTagSetMapping<T0, T1, T2, T3, 
T4>::tagset());
-  }
  };

+
+

Would you please revert those two empty lines you added? No need to 
re-review. Now I'm gonna dive back into this patch :)

Thanks,
Erik

> Kind Regards, Thomas
>
>
>
>     Thanks,
>     Marcus
>
>