[8u-dev] RFR JDK-8171194: Exception "Duplicate field name&signature in class file" should report the name and signature of the field

[serguei.spitsyn at oracle.com]

Hi Shafi,

It looks good to me.

Thanks,
Serguei


On 3/12/17 20:52, Shafi Ahmad wrote:
> Hi,
>
> May I get the second review for this simple backport.
>
> Regards,
> Shafi
>
>> -----Original Message-----
>> From: Shafi Ahmad
>> Sent: Thursday, March 09, 2017 3:39 PM
>> To: David Holmes <david.holmes at oracle.com>; hotspot-
>> dev at openjdk.java.net
>> Subject: RE: [8u-dev] RFR JDK-8171194: Exception "Duplicate field
>> name&signature in class file" should report the name and signature of the
>> field
>>
>> Hi David,
>>
>> Thank you for the review and letting me know about the enhancement
>> approval process.
>>
>> Regards,
>> Shafi
>>
>>> -----Original Message-----
>>> From: David Holmes
>>> Sent: Thursday, March 09, 2017 11:46 AM
>>> To: Shafi Ahmad <shafi.s.ahmad at oracle.com>; hotspot-
>>> dev at openjdk.java.net
>>> Subject: Re: [8u-dev] RFR JDK-8171194: Exception "Duplicate field
>>> name&signature in class file" should report the name and signature of
>>> the field
>>>
>>> Hi Shafi,
>>>
>>> On 9/03/2017 3:39 PM, Shafi Ahmad wrote:
>>>> Hi,
>>>>
>>>> Please review the backport of "JDK-8171194: Exception "Duplicate
>>>> field
>>> name&signature in class file" should report the name and signature of
>>> the field" to jdk8u-dev.
>>>> The backport is not clean even though the changes are very small.
>>>>
>>>> Webrev: http://cr.openjdk.java.net/~shshahma/8176150/webrev.00/
>>> The code changes look fine to me.
>>>
>>> But note that as this is an enhancement you will need to get an
>>> enhancement approval for it to into 8u, as well as the actual push approval:
>>>
>>> http://openjdk.java.net/projects/jdk8u/enhancement-template.html
>>>
>>> Thanks,
>>> David
>>>
>>>> Jdk10 bug: https://bugs.openjdk.java.net/browse/JDK-8171194
>>>> Jdk10 review:
>>>> http://mail.openjdk.java.net/pipermail/hotspot-dev/2017-February/025
>>>> 87
>>>> 5.html
>>>>
>>>> Testing: jprt and jtreg test.
>>>>
>>>>
>>>> Regards,
>>>> Shafi
>>>>