RFR: 8178352: BitMap::get_next_zero_offset may give wrong result on Mac

Chris Plummer chris.plummer at oracle.com
Wed May 3 04:42:45 UTC 2017


On 4/18/17 11:40 PM, Kim Barrett wrote:
>> On Apr 11, 2017, at 1:45 PM, Kim Barrett <kim.barrett at oracle.com> wrote:
>>
>>> On Apr 10, 2017, at 2:21 PM, Kim Barrett <kim.barrett at oracle.com> wrote:
>>>
>>>> On Apr 10, 2017, at 12:48 PM, Stefan Karlsson <stefan.karlsson at oracle.com> wrote:
>>>> To be consistent with the other code it in that file (res & 1) == 0 should be !(res & 1).
>>> That would be contrary to hotspot style guide; I think that should take precedence.
>> Stefan and I discussed this privately, and I�ve agreed to go with the locally consistent style here,
>> even though it�s contrary to the hotspot style guide.  Part of my decision process is related to
>> the next part of this reply.
> Here�s the updated webrev:
> http://cr.openjdk.java.net/~kbarrett/8178352/hotspot.02/
>
> Need a second reviewer, in addition to waiting for Stefan.
>
Hi Kim,

Looks good.

Chris




More information about the hotspot-dev mailing list