RFR: 8179444: AArch64: Put zero_words on a diet

Andrew Dinn adinn at redhat.com
Fri May 5 09:47:48 UTC 2017


On 03/05/17 18:05, Andrew Haley wrote:
> New version, corrected:
> . . .
> http://cr.openjdk.java.net/~aph/8179444-2/
> 
> OK?

The patch looks good (not an official review) except that I don't
understand one detail. Why does MacroAssembler::zero_words include this?


+    RuntimeAddress zero_blocks =
RuntimeAddress(StubRoutines::aarch64::zero_blocks());
+    assert(zero_blocks.target() != NULL, "zero_blocks stub has not been
generated");
+    if (StubRoutines::aarch64::complete()) {
+      trampoline_call(zero_blocks);
+    } else {
+      bl(zero_blocks);
+    }


regards,


Andrew Dinn
-----------
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander


More information about the hotspot-dev mailing list