RFR: AArch64: 8179954: AArch64: C1 and C2 volatile accesses are not sequentially consistent

[Andrew Dinn]

On 11/05/17 13:31, Andrew Haley wrote:
> Thanks for finding that bug.  It's a reminder that we need to
> concentrate on doing the minimum at this stage to ensure correctness.
> Our performance is good, and this change is not hugely profitable.  It's
> not worth risking the whole ship for.
> 
> Nevertheless, I've made a new webrev, which does the right thing.  I
> stepped through the code to make sure.  I've come this far, so I might
> as well get it right.  (Yes, I'm aware that I just fell into the sunk
> cost fallacy, but I want something to show for the work I've done.)
> 
> http://cr.openjdk.java.net/~aph/8179954-3/
> 
> In JDK 10 we should look at replacing all the explicit fences used for
> volatiles with LDAR/STLR.
> 
> OK?  I'd like two reviewers for this one.

The latest patch also looks good by eyeball.

I'm currently checking it builds and runs ok. Will gte back soon re that.

regards,


Andrew Dinn
-----------
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander