RFR: AArch64: 8179954: AArch64: C1 and C2 volatile accesses are not sequentially consistent

Stuart Monteith stuart.monteith at linaro.org
Thu May 11 18:02:12 UTC 2017


Looks good to me - a quick "sanity" quick on JCStress ran cleanly too.

On 11 May 2017 at 17:52, Andrew Dinn <adinn at redhat.com> wrote:
> On 11/05/17 17:27, Andrew Dinn wrote:
>> On 11/05/17 13:31, Andrew Haley wrote:
>>> OK?  I'd like two reviewers for this one.
>>
>> The latest patch also looks good by eyeball.
>>
>> I'm currently checking it builds and runs ok. Will gte back soon re that.
>
> Yes, it builds for me and my build runs java Hello, javac Hello.java and
> netbeans ok.
>
> I cannot guarantee that I am likely to have tested the actual fix since,
> as Andrew points out, it needs to have code with different levels of
> compilation happen to mix in the right way. But this at least suggests
> that nothing got side-swiped along the way.
>
> So, I say ship it :-)
>
> regards,
>
>
> Andrew Dinn
> -----------
> Senior Principal Software Engineer
> Red Hat UK Ltd
> Registered in England and Wales under Company Registration No. 03798903
> Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander


More information about the hotspot-dev mailing list