RFR (S) 8180482: Reformat -XX:+PrintSafepointStatistics table
Aleksey Shipilev
shade at redhat.com
Wed May 17 13:24:21 UTC 2017
Hi David,
On 05/17/2017 02:19 PM, David Holmes wrote:
> On 17/05/2017 9:02 PM, Aleksey Shipilev wrote:
>> Patch:
>> http://cr.openjdk.java.net/~shade/8180482/webrev.01/
>
> Can't say I like all the magic numbers. Is this:
>
> tty->print("[ %5s %7s %7s %7s %7s %7s ] ",
> "time:", "spin", "block", "sync", "cleanup", "vmop");
>
> really worth the effort versus:
>
> // widest column name needs 7 chars so space accordingly
> tty->print("[ time: spin block sync cleanup vmop ]");
>
> ?
Agreed, it was easier to handle with width specifiers when tidying up the code.
The final version can just use the appropriate number of spaces:
http://cr.openjdk.java.net/~shade/8180482/webrev.02/
Thanks,
-Aleksey
More information about the hotspot-dev
mailing list