RFR(XS) 8180324: failed JVMCI junit test NativeCallTest.java
mikhailo
mikhailo.seledtsov at oracle.com
Wed May 17 21:40:05 UTC 2017
Looks good,
Misha
On 05/17/2017 02:07 PM, Igor Ignatyev wrote:
> Hi Katya,
>
> the fix looks good to me.
>
> -- Igor
>> On May 17, 2017, at 1:50 PM, Ekaterina Pavlova <ekaterina.pavlova at oracle.com> wrote:
>>
>> Hi,
>>
>> Please review this small change that fixes compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/NativeCallTest.java test.
>> The test missed 'native' declaration and as result failed with UnsatisfiedLinkError when '-nativepath' flag was not passed to
>> jtreg. Now the test will fail with "Use -nativepath to specify the location of native code" error message which is more
>> understandable.
>>
>> Fixed also runtime/noClassDefFoundMsg/NoClassDefFoundMsg.java and
>> serviceability/jvmti/GetModulesInfo/JvmtiGetAllModulesTest.java tests which had the same issue.
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8180324
>> webrev: http://cr.openjdk.java.net/~epavlova//8180324/webrev.00/
>>
>> Tested by running jprt plus manual testing of fixed tests.
>>
>> thanks,
>> -katya
>>
>> p.s.
>> Igor Ignatyev volunteered to sponsor this change.
More information about the hotspot-dev
mailing list