[8u] Request for approval and review: 8180934 (XS): PutfieldError failed with UnsupportedClassVersionError

[Zoltán Majó]

Hi,


On 05/29/2017 03:51 AM, David Holmes wrote:
> On 27/05/2017 12:44 AM, harold seigel wrote:
>> Hi Zoltan,
>>
>> Instead of deleting the test, can the class file version of Bad.jasm 
>> be changed to 52 for JDK-8u?
>
> I concur. As I just wrote in the bug report I don't see how the 
> changes can be backported to 8u but the test is somehow invalid for 8u!

I agree -- thank you, Harold and David, for pointing that out. I 
mis-read the test and thought to be related to the final field updates 
handled differently in 8 and 9 (functionality added by JDK-8157181 and 
JDK-8161987, respectively).

Here is the updated webrev:
http://cr.openjdk.java.net/~zmajo/8180934/webrev.01/

>
> Also as a point of order: a RFR and a RFA are distinct and should be 
> posted separately: the RFR on hotspot-xxx-dev (as appropriate) and the 
> RFA on jdk8u-dev.

Thanks, I noted that. Should I re-send the RFA and RFR for this issue, 
or does it suffice if I do it the next time (and onwards)?

Best regards,


Zoltan


>
> Thanks,
> David
>
>> Thanks, Harold
>>
>>
>> On 5/26/2017 10:17 AM, Zoltán Majó wrote:
>>> Hi,
>>>
>>>
>>> when backporting 8160551, I also backported a test that is relevant 
>>> only for class files with version >= 53. As JDK 8 supports only 
>>> class files with version < 53, having the test in the JDK 8u test 
>>> base does not make sense. This changeset proposes to remove the test.
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8180934
>>> http://cr.openjdk.java.net/~zmajo/8180934/webrev.00/
>>>
>>> I executed all hotspot/runtime tests with the changeset (using JDK 
>>> 8u122), no problems have shown up. JPRT testing is in progress.
>>>
>>> Please note that this fix is a JDK 8u-specific fix (not a backport 
>>> of some existing fix in JDK 9).
>>>
>>> Thank you!
>>>
>>> Best regards,
>>>
>>>
>>> Zoltan
>>>
>>