RFR: 8161145: The min/max macros make hotspot tests fail to build with GCC 6

Severin Gehwolf sgehwolf at redhat.com
Wed May 31 11:55:07 UTC 2017


Hi Erik,

On Wed, 2017-05-31 at 13:07 +0200, Erik Österlund wrote:
> Hi,
> 
> I am bringing back this blast from the past. I also need a solution for 
> this for the GC interface that wishes to use <limits>.
> I propose to do what Kim suggested - to #define max max and #define min 
> min. This way the innocent "max" identifiers that have nothing to do 
> with any macros will build as they should, and any accidental consumer 
> of a potential max() macro will find a compiler error as intended. Is 
> anyone left unhappy with this solution?

I'm not. It works fine on my end. Looking forward to have this finally
fixed upstream.

Thanks,
Severin


More information about the hotspot-dev mailing list