[RFR]: 8190570: Zero fails to build on linux-sparc due undefined reference

[coleen.phillimore at oracle.com]

Seems trivial enough.  I'll check it in for you.
Coleen

On 11/8/17 3:14 PM, John Paul Adrian Glaubitz wrote:
> Hi!
>
> Anyone could review this change for me?
>
> Adrian
>
> On 11/06/2017 07:50 PM, John Paul Adrian Glaubitz wrote:
>> Hi!
>>
>> Trying to build Zero on linux-sparc currently fails with:
>>
>> === Output from failing command(s) repeated here ===
>> /usr/bin/printf "* For target hotspot_variant-zero_libjvm_gtest_objs_BUILD_GTEST_LIBJVM_link:\n"
>> * For target hotspot_variant-zero_libjvm_gtest_objs_BUILD_GTEST_LIBJVM_link:
>> (/bin/grep -v -e "^Note: including file:" <
>> /home/glaubitz/openjdk/hs/build/linux-sparcv9-normal-zero-release/make-support/failure-logs/hotspot_variant-zero_libjvm_gtest_objs_BUILD_GTEST_LIBJVM_link.log
>> || true) | /usr/bin/head -n 12
>> /home/glaubitz/openjdk/hs/build/linux-sparcv9-normal-zero-release/hotspot/variant-zero/libjvm/objs/init.o: In function `init_globals()':
>> /home/glaubitz/openjdk/hs/src/hotspot/share/runtime/init.cpp:120: undefined reference to `g1_barrier_stubs_init()'
>> collect2: error: ld returned 1 exit status
>> if test `/usr/bin/wc -l <
>> /home/glaubitz/openjdk/hs/build/linux-sparcv9-normal-zero-release/make-support/failure-logs/hotspot_variant-zero_libjvm_gtest_objs_BUILD_GTEST_LIBJVM_link.log`
>> -gt 12; then /bin/echo " ... (rest of output omitted)" ; fi
>> /usr/bin/printf "* For target hotspot_variant-zero_libjvm_objs_BUILD_LIBJVM_link:\n"
>> * For target hotspot_variant-zero_libjvm_objs_BUILD_LIBJVM_link:
>> (/bin/grep -v -e "^Note: including file:" <
>> /home/glaubitz/openjdk/hs/build/linux-sparcv9-normal-zero-release/make-support/failure-logs/hotspot_variant-zero_libjvm_objs_BUILD_LIBJVM_link.log || true) |
>> /usr/bin/head -n 12
>> /home/glaubitz/openjdk/hs/build/linux-sparcv9-normal-zero-release/hotspot/variant-zero/libjvm/objs/init.o: In function `init_globals()':
>> /home/glaubitz/openjdk/hs/src/hotspot/share/runtime/init.cpp:120: undefined reference to `g1_barrier_stubs_init()'
>> collect2: error: ld returned 1 exit status
>> if test `/usr/bin/wc -l <
>> /home/glaubitz/openjdk/hs/build/linux-sparcv9-normal-zero-release/make-support/failure-logs/hotspot_variant-zero_libjvm_objs_BUILD_LIBJVM_link.log` -gt 12; then
>> /bin/echo " ... (rest of output omitted)" ; fi
>> /usr/bin/printf "\n* All command lines available in /home/glaubitz/openjdk/hs/build/linux-sparcv9-normal-zero-release/make-support/failure-logs.\n"
>>
>> * All command lines available in /home/glaubitz/openjdk/hs/build/linux-sparcv9-normal-zero-release/make-support/failure-logs.
>> /usr/bin/printf "=== End of repeated output ===\n"
>> === End of repeated output ===
>>
>> This happens because of this snippet of code in src/hotspot/share/runtime/init.cpp:
>>
>> #if INCLUDE_ALL_GCS
>> // depends on universe_init, must be before interpreter_init (currently only on SPARC)
>> void g1_barrier_stubs_init() NOT_SPARC({});
>> #endif
>>
>> I have submitted a possible fix to webrev in [1]. Please review.
>>
>> Thanks,
>> Adrian
>>
>>> [1] http://cr.openjdk.java.net/~glaubitz/8190570/webrev.00/
>