RFR: JDK-8190418 Stop generating jvmtiEnvStub and jvmtiEnvRecommended

[David Holmes]

Hi Magnus,

On 14/11/2017 11:06 PM, Magnus Ihse Bursie wrote:
> During hotspot gensrc, we create two files, jvmtiEnvStub and 
> jvmtiEnvRecommended, which later on are explicitly excluded from the 
> build. We should just stop generating them.

cc'd Dan: Need someone who knows to chime in with what these files are 
and why they exist. The stub is like a dummy implementation that may 
have been useful for testing against. No idea what the "recommended" 
file may represent. ??

> I have built hotspot with and without this patch, and used the build 
> comparison script (compare.sh) to verify that it has not changed.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8190418
> WebRev: 
> http://cr.openjdk.java.net/~ihse/JDK-8190418-stop-generating-unneeded-jvmti-files/webrev.01 

Change itself seems fine. Not sure if jvmtiEnv.xsl is now a dead file 
that can be removed (if so we'll file a hotspot bug for that).

Thanks,
David

> 
> /Magnus
>