RFR: 8191333: Zero variant broken after 8189941

John Paul Adrian Glaubitz glaubitz at physik.fu-berlin.de
Wed Nov 15 16:04:03 UTC 2017


Hi Robbin!

On 11/15/2017 04:56 PM, Robbin Ehn wrote:
> Hi looks good, but:
> 
> 101 #define SAFEPOINT       \
>  102     if ( SafepointSynchronize::is_synchronizing()) {         \
>  103         {         \
> 
> You should not need to call SafepointSynchronize::is_synchronizing().
> SafepointMechanism::block_if_requested(THREAD) takes care of everything.

What about the handles?

> And if you ever plan to add thread-local handshake support to zero that
> won't work.
You mean, it won't work with the above code?

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz at debian.org
`. `'   Freie Universitaet Berlin - glaubitz at physik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913


More information about the hotspot-dev mailing list