RFR: 8191333: Zero variant broken after 8189941

John Paul Adrian Glaubitz glaubitz at physik.fu-berlin.de
Wed Nov 15 18:44:24 UTC 2017


On 11/15/2017 05:48 PM, coleen.phillimore at oracle.com wrote:
>> What about the handles?
> 
> Honestly, after looking at it, I have no idea.  It seems like something you should remove and see if that works.  The comment says that there should be no
> active handles.  Maybe have a NoHandleMark unconditionally? then SafepointMechanism::block_if_requested(THREAD) so that the comment is actually an assertion. 
> Sorry for too quick review.

I just tested that. This builds fine. Whether it's the way to go, I'm
not sure. Maybe Robbin can make a statement regarding this.

The freshly JVM is run during the build if I remember correctly, so I
assume it works with this particular change.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz at debian.org
`. `'   Freie Universitaet Berlin - glaubitz at physik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913


More information about the hotspot-dev mailing list