RFR(XS) 8190975: Tests which run with "--limit-modules java.base" could fail when Graal is used as JIT

[David Holmes]

On 17/11/2017 7:28 PM, Alan Bateman wrote:
> On 17/11/2017 09:24, David Holmes wrote:
>> On 17/11/2017 5:54 PM, Alan Bateman wrote:
>>> On 16/11/2017 23:49, Ekaterina Pavlova wrote:
>>>> Hi all,
>>>>
>>>> The following change fixes tests which run with "--limit-modules 
>>>> java.base" and as result could fail
>>>> in case they are run in Graal mode. The fix adds 
>>>> "jdk.internal.vm.compiler" module so Graal classes
>>>> can be loaded during Graal initialization.
>>>>
>>>>
>>>>    JBS:  https://bugs.openjdk.java.net/browse/JDK-8190975
>>>> webrev: 
>>>> http://cr.openjdk.java.net/~epavlova//8190975/webrev.00/index.html
>>> This looks okay although you don't need to list java.base as all 
>>> modules require java.base.
>>
>> Isn't the point to limit the observable modules to only java.base (and 
>> now the compiler module) ?
> `--limit-modules` will limit the set of observable modules to the 
> transitive closure of the modules that you specify to the option. If you 
> run `java --limit-modules jdk.internal.vm.compiler --list-modules` then 
> you'll see what I mean.

Ah I see what you mean - java.base is redundant now.

David

> -Alan
>