RFR: 8187227: __m68k_cmpxchg() is not being used correctly
John Paul Adrian Glaubitz
glaubitz at physik.fu-berlin.de
Tue Nov 21 12:02:59 UTC 2017
On 11/21/2017 11:41 AM, John Paul Adrian Glaubitz wrote:
> On 11/21/2017 11:37 AM, Andrew Haley wrote:
>>> This sounds like a good idea. I'll look into using that. Might make the
>>> code also more readable. Although I would be a bit worried that this
>>> introduces too many layers of indirection, wouldn't it?
>>
>> It's a a compiler builtin, so it should be (at least) as good as inline
>> assembly. It's GCC-specific, but that shouldn't matter.
>
> Ok, that's what I guessed but I wasn't sure about. Thanks for confirming
> it.
I have just talked to Andreas Schwab, a colleague of mine at SUSE, who
has been working on the Linux m68k stuff for a long time. According to
him, the compiler built-ins didn't exist back then for m68k which is why
the platform-specific functions exist in OpenJDK. They do now, however.
I'll just remove them for m68k and test if that works as expected. If
yes, we should change this changeset to do that instead of fixing the
platform-specific functions.
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer - glaubitz at debian.org
`. `' Freie Universitaet Berlin - glaubitz at physik.fu-berlin.de
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
More information about the hotspot-dev
mailing list