RFR: JDK-8191202 Remove duplicated jmm.h

coleen.phillimore at oracle.com coleen.phillimore at oracle.com
Tue Nov 21 15:51:25 UTC 2017


I think this looks good. I'd rather these be in the same place for now 
until a better destination is agreed upon.
thank you for removing this file.
Coleen

On 11/21/17 8:55 AM, Magnus Ihse Bursie wrote:
> On 2017-11-21 12:49, David Holmes wrote:
>> Hi Magnus,
>>
>> Seems to me that jmm is an interface exported by the VM, so the 
>> hotspot version of the header is the one that should survive IMO.
>
> We had a similar discussion about the other header files, were we kept 
> the JDK version, for the time being. A bug, JDK-8190484 was opened to 
> discuss the final location of the one remaining copy. This has in fact 
> already prepared for the removal of the duplicated jmm.h, since it's 
> titled "Revisit the source location of jvm.h and jmm.h".
>
> I'd prefer to treat this one similar to the other duplicated header 
> files, and keep the JDK version for the time being. And then leaving 
> it to whoever solves JDK-8190484 to figure out a proper location. Are 
> you okay with that?
>
> /Magnus
>
>> David
>>
>> On 21/11/2017 9:42 PM, Magnus Ihse Bursie wrote:
>>> As part of the effort to remove duplicated files between Hotspot and 
>>> JDK, the turn has now come to jmm.h.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8191202
>>> WebRev: 
>>> http://cr.openjdk.java.net/~ihse/JDK-8191202-remove-duplicated-jmm-h/webrev.01 
>>>
>>>
>>> /Magnus
>



More information about the hotspot-dev mailing list