Zero broken again, probably due to JDK-8189871

David Holmes david.holmes at oracle.com
Tue Nov 21 22:10:33 UTC 2017


Adrian,

On 22/11/2017 12:12 AM, John Paul Adrian Glaubitz wrote:
>> Which got broken by JDK-8189170.

Sincerest apologies for that. I should have grepped for 
os::Linux::is_initial_thread usage.

David

> Complete fix is:
> 
> glaubitz at z6:..upstream/hs> hg diff
> diff -r 1f77dcf5577e src/hotspot/os_cpu/linux_zero/os_linux_zero.cpp
> --- a/src/hotspot/os_cpu/linux_zero/os_linux_zero.cpp   Tue Nov 21 13:48:28 2017 +0100
> +++ b/src/hotspot/os_cpu/linux_zero/os_linux_zero.cpp   Tue Nov 21 15:12:03 2017 +0100
> @@ -372,7 +372,7 @@
>     // The initial thread has a growable stack, and the size reported
>     // by pthread_attr_getstack is the maximum size it could possibly
>     // be given what currently mapped.  This can be huge, so we cap it.
> -  if (os::Linux::is_initial_thread()) {
> +  if (os::is_primordial_thread()) {
>       stack_bytes = stack_top - stack_bottom;
> 
>       if (stack_bytes > JavaThread::stack_size_at_create())
> diff -r 1f77dcf5577e src/hotspot/share/oops/accessBackend.hpp
> --- a/src/hotspot/share/oops/accessBackend.hpp  Tue Nov 21 13:48:28 2017 +0100
> +++ b/src/hotspot/share/oops/accessBackend.hpp  Tue Nov 21 15:12:03 2017 +0100
> @@ -82,7 +82,7 @@
>   #ifdef SUPPORTS_NATIVE_CX8
>     struct PossiblyLockedAccess: public IntegralConstant<bool, false> {};
>   #else
> -  struct PossiblyLockedAccess: public IntegralConstant<bool, (sizeof(T) > 4)>::value> {};
> +  struct PossiblyLockedAccess: public IntegralConstant<bool, (sizeof(T) > 4)> {};
>   #endif
> 
>     template <DecoratorSet decorators, typename T>
> glaubitz at z6:..upstream/hs>
> 
> I have filed JDK-8191663 and will push a webrev shortly.
> 
> Adrian
> 


More information about the hotspot-dev mailing list