RFR: 8187227: Zero should use compiler built-ins for atomics on linux-m68k

Andrew Haley aph at redhat.com
Thu Nov 23 14:15:33 UTC 2017


On 23/11/17 14:01, John Paul Adrian Glaubitz wrote:
> Hi Robbin!
> 
> On 11/23/2017 02:38 PM, Robbin Ehn wrote:
>> Hi, a bit out of scope, mostly for Andrew.
>>
>> Not sure how old compiler you want to be use but __sync_XXX is 'legacy' since 4.7.
>> So shouldn't we change to __atomic_XXX ?

No.  There's no need, and the __atomic builtins aren't quite as
convenient to use.  There's certainly no reason to change at this
point.

> Also, since this particular changeset only removes the m68k-specific code,
> I don't think we should incorporate your suggested change in this changeset,
> but I guess it should be good to go after the ARM- and m68k-specific functions
> have been removed.
Take care: it's not absolutely guaranteed that the GCC builtins are
correct for HotSpot.  Don't change anything that isn't broken.

-- 
Andrew Haley
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671


More information about the hotspot-dev mailing list