CodeCacheExpansionSize too small for Zero on ppc32/ppc64

[John Paul Adrian Glaubitz]

Hi Tobias!

On 11/28/2017 03:15 PM, Tobias Hartmann wrote:
> seems like this is due to my fix for JDK-8179026 [1] which now enforces the CodeCacheExpansionSize to be >=
> os::vm_page_size(). I did this because in CodeCache::initialize() we align the size anyway:
> 
> CodeCacheExpansionSize = align_up(CodeCacheExpansionSize, os::vm_page_size());
> 
> Since other platforms define 32*K as their default value as well, it might be best to just set the lower limit to 32*K
> instead of os::vm_page_size() and let above alignment code take care of adjusting the size.
Thanks a lot for your quick reply! Good to know that this regression was just
introduced recently, I already thought I missed some other ppc-specific patch.

So, looking at your changeset:

> http://hg.openjdk.java.net/jdk/hs/rev/7f40c1cdde28#l3.1

Should we just set the sizes there from the fixed values defined in globals.hpp
for all the cases where it's set to os::vm_page_size() or just for
CodeCacheMinBlockLength?

Adrian

-- 
  .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz at debian.org
`. `'   Freie Universitaet Berlin - glaubitz at physik.fu-berlin.de
   `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913