RFR: 8191870: Remove badJNIHandle
coleen.phillimore at oracle.com
coleen.phillimore at oracle.com
Tue Nov 28 14:58:56 UTC 2017
On 11/27/17 6:48 PM, Kim Barrett wrote:
>> On Nov 27, 2017, at 3:43 PM, coleen.phillimore at oracle.com wrote:
>>
>>
>>
>> On 11/27/17 3:21 PM, Kim Barrett wrote:
>>>> On Nov 27, 2017, at 10:19 AM, coleen.phillimore at oracle.com wrote:
>>>>
>>>>
>>>> My question was why there's a command line option, which seems like nobody on earth should use it. Yes, we don't need to zap for product, only for debug.
>>> So remove the CLA and instead #ifdef ASSERT the zapping.
>> Yes.
>>> I’d be okay with that. Another CLA bites the dust.
>> What looks like a pointless one at that.
>>
>> Coleen
> New webrev with ZapJNIHandleArea removed.
>
> full: http://cr.openjdk.java.net/~kbarrett/8191870/open.01/
> incr: http://cr.openjdk.java.net/~kbarrett/8191870/open.01.inc/
>
http://cr.openjdk.java.net/~kbarrett/8191870/open.01/src/hotspot/share/runtime/jniHandles.hpp.udiff.html
I think you need PRODUCT_RETURN for zap() in case the optimized target
still builds. Otherwise, looks good.
Coleen
More information about the hotspot-dev
mailing list