CodeCacheExpansionSize too small for Zero on ppc32/ppc64

[Tobias Hartmann]

On 28.11.2017 16:12, John Paul Adrian Glaubitz wrote:
> Looks like you're missing an include here:
> 
> if test `/usr/bin/wc -l <
> /home/glaubitz/openjdk/hs/build/linux-ppc64-normal-zero-release/make-support/failure-logs/hotspot_variant-zero_libjvm_objs_basicLock.o.log`
> -gt 12; then /bin/echo "   ... (rest of output omitted)" ; fi
> /usr/bin/printf "* For target hotspot_variant-zero_libjvm_objs_biasedLocking.o:\n"
> * For target hotspot_variant-zero_libjvm_objs_biasedLocking.o:
> (/bin/grep -v -e "^Note: including file:" < 
> /home/glaubitz/openjdk/hs/build/linux-ppc64-normal-zero-release/make-support/failure-logs/hotspot_variant-zero_libjvm_objs_biasedLocking.o.log
> || true) | /usr/bin/head -n 12
> In file included from /home/glaubitz/openjdk/hs/src/hotspot/share/utilities/debug.hpp:30:0,
>                  from /home/glaubitz/openjdk/hs/src/hotspot/share/utilities/globalDefinitions.hpp:29,
>                  from /home/glaubitz/openjdk/hs/src/hotspot/share/utilities/align.hpp:28,
>                  from /home/glaubitz/openjdk/hs/src/hotspot/share/runtime/globals.hpp:28,
>                  from /home/glaubitz/openjdk/hs/src/hotspot/share/memory/allocation.hpp:28,
>                  from /home/glaubitz/openjdk/hs/src/hotspot/share/logging/logLevel.hpp:27,
>                  from /home/glaubitz/openjdk/hs/src/hotspot/share/logging/log.hpp:27,
>                  from /home/glaubitz/openjdk/hs/src/hotspot/share/runtime/biasedLocking.cpp:26:
> /home/glaubitz/openjdk/hs/src/hotspot/share/runtime/globals.hpp:93:54: error: ‘os’ has not been declared
>  define_pd_global(intx, CodeCacheExpansionSize,       os::vm_page_size());

Thanks, I've just noticed this as well but it seems we cannot include runtime/os.hpp from globals.hpp without
introducing circular dependencies..

I guess it's best to go with the straight forward fix of setting the min value to 32*K:
http://cr.openjdk.java.net/~thartmann/8191996/webrev.00/

What do you think?

Best regards,
Tobias