CodeCacheExpansionSize too small for Zero on ppc32/ppc64

[David Holmes]

 >   define_pd_global(intx, CodeCacheExpansionSize, 
os::vm_page_size());

I thought the values here had to be constants ?? The appropriate level 
of initialization may not have happened when this default value would be 
assigned!

David

On 29/11/2017 1:12 AM, John Paul Adrian Glaubitz wrote:
> On 11/28/2017 04:07 PM, John Paul Adrian Glaubitz wrote:
>> Will test the change on all relevant targets now. Might take a bit
>> longer, but I'll report back as soon as possible.
> 
> Looks like you're missing an include here:
> 
> if test `/usr/bin/wc -l < 
> /home/glaubitz/openjdk/hs/build/linux-ppc64-normal-zero-release/make-support/failure-logs/hotspot_variant-zero_libjvm_objs_basicLock.o.log` 
> -gt 12; then /bin/echo "   ... (rest of output omitted)" ; fi
> /usr/bin/printf "* For target 
> hotspot_variant-zero_libjvm_objs_biasedLocking.o:\n"
> * For target hotspot_variant-zero_libjvm_objs_biasedLocking.o:
> (/bin/grep -v -e "^Note: including file:" <  
> /home/glaubitz/openjdk/hs/build/linux-ppc64-normal-zero-release/make-support/failure-logs/hotspot_variant-zero_libjvm_objs_biasedLocking.o.log 
> || true) | /usr/bin/head -n 12
> In file included from 
> /home/glaubitz/openjdk/hs/src/hotspot/share/utilities/debug.hpp:30:0,
>                   from 
> /home/glaubitz/openjdk/hs/src/hotspot/share/utilities/globalDefinitions.hpp:29, 
> 
>                   from 
> /home/glaubitz/openjdk/hs/src/hotspot/share/utilities/align.hpp:28,
>                   from 
> /home/glaubitz/openjdk/hs/src/hotspot/share/runtime/globals.hpp:28,
>                   from 
> /home/glaubitz/openjdk/hs/src/hotspot/share/memory/allocation.hpp:28,
>                   from 
> /home/glaubitz/openjdk/hs/src/hotspot/share/logging/logLevel.hpp:27,
>                   from 
> /home/glaubitz/openjdk/hs/src/hotspot/share/logging/log.hpp:27,
>                   from 
> /home/glaubitz/openjdk/hs/src/hotspot/share/runtime/biasedLocking.cpp:26:
> /home/glaubitz/openjdk/hs/src/hotspot/share/runtime/globals.hpp:93:54: 
> error: ‘os’ has not been declared
>   define_pd_global(intx, CodeCacheExpansionSize,       os::vm_page_size());
>