RFR(S) 8191437: AOT doesn't work easily after thread local handshakes

dean.long at oracle.com dean.long at oracle.com
Wed Nov 29 00:49:51 UTC 2017


On 11/28/17 4:12 PM, Vladimir Kozlov wrote:

> On 11/28/17 10:00 AM, dean.long at oracle.com wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8191437
>>
>> http://cr.openjdk.java.net/~dlong/8191437/webrev.hs/
>
> VM changes looks fine to me.
>

Thanks Vladimir.

>>
>> http://cr.openjdk.java.net/~dlong/8191437/webrev.graal/
>>
>>
>> This change adds support for thread local handshakes to Graal for x64 
>> and SPARC.  Graal generates a different instruction encoding on x64 
>> than C1/C2, so I had to account for that difference in
>
> I assume it works in all cases now (C1, C2, Graal generated code) ?

Yes.

>
>> sharedRuntime_x86_64.cpp.  I'm including the Graal changes because I 
>> would like to push them together with the HotSpot changes.
>
> I would still suggest to do review and testing in Labs.
>

Yes, I waited until it was reviewed and pushed upstream to Graal before 
sending out this RFR.

dl

> Thanks,
> Vladimir
>
>>
>>
>> dl
>>



More information about the hotspot-dev mailing list