[10] (S) RFR 8191788: add jdk.internal.vm.compiler to --limit-modules if -Djvmci.Compiler=graal is in the command line

[Vladimir Kozlov]

Thank you, David

On 11/28/17 8:57 PM, David Holmes wrote:
> Hi Vladimir,
> 
> On 29/11/2017 9:51 AM, Vladimir Kozlov wrote:
>> http://cr.openjdk.java.net/~kvn/8191788/webrev.00/
>> https://bugs.openjdk.java.net/browse/JDK-8191788
>>
>> This is redo of JDK-8190975 [1] fix which added jdk.internal.vm.compiler to tests which have --limit-modules option. 
>> Unfortunately tests start failing on SPARC where Graal (jdk.internal.vm.compiler) is not available. JDK-8191653 [2] 
>> reversed 8190975 changes to fix that problem.
>>
>> This fix adds jdk.internal.vm.compiler to --limit-modules list in JVM only when Graal is used: when it is explicitly 
>> specified with -Djvmci.Compiler=graal or in default case and when UseJVMCICompiler is true.
> 
> This seems a reasonable way to handle this - at least for now.
> 
> Typo:
> 
> 3379     // and --limit-modules are spcified.
> 
> spcified -> specified

Will fix.

Vladimir

> 
> Thanks,
> David
> -----
> 
>> I tested the fix with failed tests from JDK-8190975 which are mostly AppCDS tests in test/runtime/appcds/jigsaw and 
>> also test/jdk/java/lang/String/concat/WithSecurityManager.java
>>
>> I think this fix may break upgradeable status of Graal (for Oracle Labs version of Graal).
>> But it should be fine since it is only used with --limit-modules which is not used by Labs.
>>
>> Thanks,
>> Vladimir
>>
>> [1] http://hg.openjdk.java.net/jdk/hs/rev/8deb7919d118
>> [2] http://hg.openjdk.java.net/jdk/hs/rev/b38d8aadcada