CodeCacheExpansionSize too small for Zero on ppc32/ppc64
Tobias Hartmann
tobias.hartmann at oracle.com
Wed Nov 29 08:06:39 UTC 2017
Hi,
On 29.11.2017 00:34, David Holmes wrote:
>>> I thought the values here had to be constants ?? The appropriate level of initialization may not have happened when
>>> this default value would be assigned!
Yes, I came to the same conclusion. I've fixed it by using a constant lower bound:
http://hg.openjdk.java.net/jdk/hs/rev/646ed97b7e0d
> I'd certainly want to investigate exactly when in the initialization sequence these will get evaluated. I think range
> usage may be safer than default value, but this needs examining!
Yes, I think the range usage is okay because it's only evaluated during argument processing
(Arguments::process_argument()). We have existing uses in range checks:
http://hg.openjdk.java.net/jdk/hs/file/5a449dbca6d0/src/hotspot/share/runtime/globals.hpp#l643
Thanks,
Tobias
More information about the hotspot-dev
mailing list