RFR: 8191860: Add perfData.inline.hpp

David Holmes david.holmes at oracle.com
Wed Nov 29 10:11:43 UTC 2017


Hi Stefan,

On 24/11/2017 11:21 PM, Stefan Karlsson wrote:
> Hi all,
> 
> Please review this patch to create a perfData.inline.hpp file and move 
> inline functions in perfData.hpp that depend on functions in other 
> .inline.hpp files.
> 
> http://cr.openjdk.java.net/~stefank/8191860/webrev.01/
> https://bugs.openjdk.java.net/browse/JDK-8191860
> 
> Note 1: I consider growableArray.hpp to be an .inline.hpp in disguise, 
> since it includes allocation.inline.hpp.

Is that why you didn't #include it instead of forward declaring:

+ template <typename T> class GrowableArray;

?

> Note 2: Some .hpp files that used to include perfData.hpp now explicitly 
> includes allocation.inline.hpp. We should deal with that, but in another 
> RFE.

Yes we should deal with that - but the fanout from these changes can get 
huge. I don't relish trying to refactor arguments.hpp into 
arguments.inline.hpp for example.

Cheers,
David

> thanks,
> StefanK


More information about the hotspot-dev mailing list