RFR: 8192061: Clean up allocation.inline.hpp includes

coleen.phillimore at oracle.com coleen.phillimore at oracle.com
Wed Nov 29 13:15:31 UTC 2017


Hi Stefan,  I looked at the whole review and it's not hard to review.  I 
love these sort of changes.

Have you tested this on all platforms that we support?  I was wondering 
if SAP should do the same.  It seems like sort of a big change to get in 
by Friday but not impossible.

Thanks,
Coleen

On 11/29/17 6:21 AM, Stefan Karlsson wrote:
> Hi all,
>
> Please review this patchset to clean up our includes of 
> allocation.inline.hpp and move usages of its functions out from header 
> files into .cpp and .inline.hpp files.
>
> http://cr.openjdk.java.net/~stefank/8192061/webrev.01.all
>
> I've split this patch into multiple separate patches and tried to 
> group them according to HotSpot area, to make it easier to review. I 
> can also create separate bugs for this, if that's preferable.
>
> GC:
> http://cr.openjdk.java.net/~stefank/8192061/webrev.01.00.GC.g1ConcurrentRefine/ 
>
> http://cr.openjdk.java.net/~stefank/8192061/webrev.01.01.GC.spaceCounters/ 
>
> http://cr.openjdk.java.net/~stefank/8192061/webrev.01.02.GC.g1ParScanThreadState.hpp/ 
>
>
> RT:
> http://cr.openjdk.java.net/~stefank/8192061/webrev.01.03.GC.adaptivePaddedAverage/ 
>
> http://cr.openjdk.java.net/~stefank/8192061/webrev.01.04.RT.diagnosticArgument/ 
>
> http://cr.openjdk.java.net/~stefank/8192061/webrev.01.05.RT.methodHandles/ 
>
> http://cr.openjdk.java.net/~stefank/8192061/webrev.01.06.RT.constantPool/
> http://cr.openjdk.java.net/~stefank/8192061/webrev.01.07.RT.sharedPathsMiscInfo/ 
>
> http://cr.openjdk.java.net/~stefank/8192061/webrev.01.08.RT.generateOopMap/ 
>
> http://cr.openjdk.java.net/~stefank/8192061/webrev.01.09.RT.objectMonitor/ 
>
> http://cr.openjdk.java.net/~stefank/8192061/webrev.01.10.RT.arguments/
> http://cr.openjdk.java.net/~stefank/8192061/webrev.01.11.RT.osThread/
> http://cr.openjdk.java.net/~stefank/8192061/webrev.01.12.resourceArea/
> http://cr.openjdk.java.net/~stefank/8192061/webrev.01.13.RT.array/
> http://cr.openjdk.java.net/~stefank/8192061/webrev.01.14.RT.test_logMessage/ 
>
> http://cr.openjdk.java.net/~stefank/8192061/webrev.01.15.RT.park/
>
> SHARED:
> http://cr.openjdk.java.net/~stefank/8192061/webrev.01.16.SHARED.growableArray/ 
>
> http://cr.openjdk.java.net/~stefank/8192061/webrev.01.17.SHARED.removeIncludes/ 
>
> http://cr.openjdk.java.net/~stefank/8192061/webrev.01.18.SHARED.precompiled/ 
>
>
> Thanks,
> StefanK



More information about the hotspot-dev mailing list