RFR: 8192154 - JVM crashes inside some chroot environments on linux

[David Holmes]

Hi Bob,

On 30/11/2017 7:43 AM, Bob Vandette wrote:
> Please review this robustness fix to the Container support recently added to Hotspot.
> 
> BUG:
> https://bugs.openjdk.java.net/browse/JDK-8192154
> 
> WEBREV:
> http://cr.openjdk.java.net/~bobv/8192154/webrev/
> 
> In the event that there is a partial setup of the cgroup subsystems, it’s
> possible that the VM will crash.
> 
> The change moves NULL checking earlier in the scanning of the cgroup subsystems.

The change looks good.

BTW:

326   if (mntinfo != NULL) fclose(mntinfo);
391   if (cgroup != NULL) fclose(cgroup);

in both cases the value can't be NULL as in that case you've already 
returned from the function.

Thanks,
David

> Tested with jtreg container tests and Mach5.
> 
> Bob.
> 
>