RFR (L) 8186777: Make Klass::_java_mirror an OopHandle
Tobias Hartmann
tobias.hartmann at oracle.com
Mon Oct 2 15:18:58 UTC 2017
Hi Coleen,
On 28.09.2017 23:36, coleen.phillimore at oracle.com wrote:
> http://cr.openjdk.java.net/~coleenp/8186777.02/webrev/
>
> Can I get at least 3 reviewers? One from each of the compiler, gc, and runtime group at least since there are changes
> to all 3.
The compiler changes look good to me.
Found a little typo:
- In line 1776 of memnode.cpp: it should be "loads" instead of "load"
I just wanted to mention that SharkIntrinsics::do_Object_getClass() would need to be fixed as well but I've seen that
you filed JDK-8171853 [1] to remove Shark which is broken with JDK 9 anyway.
Best regards,
Tobias
[1] https://bugs.openjdk.java.net/browse/JDK-8171853
More information about the hotspot-dev
mailing list