JDK10/RFR(M): 8172232: SPARC ISA/CPU feature detection is broken/insufficient (on Linux).

[Patric Hedlin]

Thanks for reviewing Vladimir.

On 09/29/2017 08:56 PM, Vladimir Kozlov wrote:
> In general it is fine. Few notes.
> You use ifdef DEBUG_SPARC_CAPS which is undefed at the beginning. Is 
> it set by gcc by default?
>
Removed.

> Coding style for methods definitions - open parenthesis should be on 
> the same line:
>
> +  bool match(const char* s) const
> +  {
>
Updated/re-formated.

Refreshed webrev.

@Adrian: Please validate.

Best regards,
Patric

> Thanks,
> Vladimir
>
> On 9/29/17 6:08 AM, Patric Hedlin wrote:
>> Dear all,
>>
>> I would like to ask for help to review the following change/update:
>>
>> Issue:  https://bugs.openjdk.java.net/browse/JDK-8172232
>>
>> Webrev: http://cr.openjdk.java.net/~phedlin/tr8172232/
>>
>>
>> 8172232: SPARC ISA/CPU feature detection is broken/insufficient (on 
>> Linux).
>>
>>      Subsumes (duplicate) JDK-8186579: 
>> VM_Version::platform_features() needs update on linux-sparc.
>>
>>
>> Caveat:
>>
>>      This update will introduce some redundancies into the code base, 
>> features and definitions
>>      currently not used, addressed by subsequent bug or feature 
>> updates/patches. Fujitsu HW is
>>      treated very conservatively.
>>
>>
>> Testing:
>>
>>      JDK9/JDK10 local jtreg/hotspot
>>
>>
>> Thanks to Adrian for additional test (and review) support.
>>
>> Tested-By: John Paul Adrian Glaubitz <glaubitz at physik.fu-berlin.de>
>>
>>
>> Best regards,
>> Patric
>>