RFR (L, but tedious) 8188220: Remove Atomic::*_ptr() uses and overloads from hotspot

[David Holmes]

On 12/10/2017 5:29 PM, Kim Barrett wrote:
>> On Oct 11, 2017, at 7:07 AM, coleen.phillimore at oracle.com wrote:
>>
>>
>>
>> On 10/11/17 4:12 AM, Robbin Ehn wrote:
>>> On 10/11/2017 10:09 AM, David Holmes wrote:
>>>> On 11/10/2017 5:45 PM, Erik Österlund wrote:
>>>>
>>>> Removing the operation is a different argument to renaming it. Most of the above argues for removing it. :)
>>>
>>> +1 on removing
>>
>> Thank you for all your feedback.  Erik best described what I was thinking.  I will remove it then.  There were not that many instances and one instance that people thought would be useful, needed the old return value.
> 
> I’ve already registered my objection to removal.  I disagree with several of Erik’s points, which don’t
> address or miss the issues brought up in the original discussion that led to its introduction, as quoted
> by David.
> 
> I’m still slogging my way through the review, maybe about 3/4 of the way through.
> 
> I’ve found a number of real problems, some pre-existing and discovered by looking at the code
> around your changes; I think there are a couple of ABA bugs, for example.  I’m worried that I’m
> missing some too, because I’m getting burned out from reading reams of lock-free code.  This
> is *really* hard, and I very much wish it had been broken up into more easily digestible chunks.

I can't see how Coleen's changes can have introduced any bugs like that. 
So if there are ABA or other issues, then I think we would deal with 
them separately.

Cheers,
David

>