RFR(M): 8189102: All tools should support -?, -h and --help

Lindenmaier, Goetz goetz.lindenmaier at sap.com
Fri Oct 13 06:38:59 UTC 2017


Hi Vladimir, 

added that for jaotc, thanks!

Best regards,
  Goetz.

> -----Original Message-----
> From: hotspot-dev [mailto:hotspot-dev-bounces at openjdk.java.net] On
> Behalf Of Vladimir Kozlov
> Sent: Donnerstag, 12. Oktober 2017 01:04
> To: hotspot-dev at openjdk.java.net
> Subject: Re: RFR(M): 8189102: All tools should support -?, -h and --help
> 
> You missed AOT tool jaotc:
> 
> http://hg.openjdk.java.net/jdk10/hs/file/44117bc2bedf/src/jdk.aot/share/cl
> asses/jdk.tools.jaotc/src/jdk/tools/jaotc/Options.java#l230
> 
>      }, new Option("  --help                     Print this usage message", false, "--help",
> "-h", "-?") {
> 
> Vladimir
> 
> On 10/11/17 1:06 PM, Lindenmaier, Goetz wrote:
> > Hi
> >
> > The tools in jdk should all show the same behavior wrt. help flags.
> > This change normalizes the help flags of a row of the tools in the jdk.
> > Java accepts -?, -h and --help, thus I changed the tools to support
> > these, too.  Some tools exited with '1' after displaying the help message,
> > I turned this to '0'.
> >
> > Maybe this is not the right mailing list for this, please advise.
> >
> > Please review this change. I please need a sponsor.
> > http://cr.openjdk.java.net/~goetz/wr17/8189102-
> helpMessage/webrev.01/
> >
> > In detail, this fixes the help message of the following tools:
> > jar          -? -h --help;  added -?.
> > jarsigner    -? -h --help;  added --help. -help accepted but not documented.
> > javac        -?    --help;  added -?. Removed -help. -h is taken for other
> purpose
> > javadoc      -? -h --help;  added -h -?. Removed -help
> > javap        -? -h --help;  added -h. -help accepted but no more documented.
> > jcmd         -? -h --help;  added -? --help. -help accepted but no more
> documented. Changed return value to '0'
> > jdb          -? -h --help;  added -? -h --help. -help accepted but no more
> documented.
> > jdeprscan    -? -h --help;  added -?
> > jinfo        -? -h --help;  added -? --help. -help accepted but no more
> documented.
> > jjs             -h --help;  Replaced -help by --help. Adding more not straight
> forward.
> > jps          -? -h --help;  added -? --help. -help accepted but no more
> documented.
> > jshell       -? -h --help;  added -?
> > jstat        -? -h --help;  added -h --help. -help accepted but no more
> documented.
> >
> > Best regards,
> >    Goetz.
> >


More information about the hotspot-dev mailing list