RFR: 8189333: Fix Zero build after Atomic::xchg changes

[coleen.phillimore at oracle.com]

Thank you for the patch.  I have scripts to remember these options. 
There used to be other options but it doesn't look like I need them now.
thanks,
Coleen

On 10/16/17 9:45 AM, Roman Kennke wrote:
> Hi Coleen,
>
> Nope. It fails with this (and a bunch of similar) errors:
> https://paste.fedoraproject.org/paste/cWKozoxY23z72~EMm0BPBA 
> <https://paste.fedoraproject.org/paste/cWKozoxY23z72%7EEMm0BPBA>
>
> It does build with this additional patch:
> http://cr.openjdk.java.net/~rkennke/fix-zero-coleen/webrev/ 
> <http://cr.openjdk.java.net/%7Erkennke/fix-zero-coleen/webrev/>
>
> I.e.:
> - cast BasicLock to markOop by using markOopDesc::encode()
> - use oopDesc::cas_set_mark() instead of the raw Atomic ops (probably 
> not strictly required for this change, but still much nicer)
>
>
> You should not require any build scripts for Zero though. Simply run 
> configure with --with-jvm-variants=zero and build in the corresponding 
> linux-x86_64-normal-zero-slowdebug or similar directory using the 
> usual make calls.
>
>
>>
>> Hi Roman, Can you build zero with this changeset?
>>
>> http://cr.openjdk.java.net/~coleenp/8188220.03/webrev/index.html
>>
>> My scripts for building zero are broken now.
>>
>> thanks,
>> Coleen
>>
>> On 10/15/17 5:40 PM, Roman Kennke wrote:
>>> Am 15.10.2017 um 23:32 schrieb David Holmes:
>>>> Hi Roman,
>>>>
>>>> On 16/10/2017 7:12 AM, Roman Kennke wrote:
>>>>> Zero debug build has been broken by: JDK-8187977: Generalize 
>>>>> Atomic::xchg to use templates.
>>>>>
>>>>> This patch fixes it by casting the unsigned literal to jint:
>>>>>
>>>>> http://cr.openjdk.java.net/~rkennke/8189333/webrev.00/ 
>>>>> <http://cr.openjdk.java.net/%7Erkennke/8189333/webrev.00/>
>>>>
>>>> Looks fine.
>>>>
>>>> I can push this for you straight away (relatively speaking :) ) 
>>>> under the trivial rule.
>>> Thanks!
>>>
>>> Roman
>>
>