RFR: 8189359: Move native weak oops cleaning out of ReferenceProcessor
Kim Barrett
kim.barrett at oracle.com
Tue Oct 17 21:11:07 UTC 2017
> On Oct 17, 2017, at 4:57 PM, Stefan Karlsson <stefan.karlsson at oracle.com> wrote:
> Here are the updated webrevs:
> http://cr.openjdk.java.net/~stefank/8189359/webrev.01.delta
> http://cr.openjdk.java.net/~stefank/8189359/webrev.01
------------------------------------------------------------------------------
src/hotspot/share/gc/shared/weakProcessor.hpp
33 // New contains of weak oops added to this class will automatically
Sorry, but that's garbled, and I'm not sure what is intended.
Previous version had "sets" instead of "contains", which seemed okay
to me.
------------------------------------------------------------------------------
src/hotspot/share/gc/shared/weakProcessor.hpp
45 // Visit all oop*s and apply the given clousre.
s/clousre/closure/
------------------------------------------------------------------------------
src/hotspot/share/gc/shared/weakProcessor.hpp
41 // The complete closure is used as a post-processing step called
42 // after each container has been processed.
I think a comma is needed between "step" and "called". But we were
discussing in chat whether this closure is even needed. I think it
isn't...
------------------------------------------------------------------------------
src/hotspot/share/gc/shared/weakProcessor.hpp
37 // Visit all oop*s and either apply the keep_alive closure if the referenced
38 // object is considered alive by the is_alive closure, otherwise do some
39 // container specific cleanup of element holding the oop.
Suggest
s/either//
s/, otherwise/. Otherwise/
------------------------------------------------------------------------------
More information about the hotspot-dev
mailing list