RFR(XL): 8185640: Thread-local handshakes

Robbin Ehn robbin.ehn at oracle.com
Tue Oct 24 14:03:37 UTC 2017


On 2017-10-23 18:36, Andrew Haley wrote:
> This is a bad way to handle supports_thread_local_poll():

I agree, is this what you had in mind:
Incremental:
http://cr.openjdk.java.net/~rehn/8185640/v4/Support-Check-Haley-6/webrev/

Thanks, Robbin

> 
>    static bool supports_thread_local_poll() {
> #if defined(AMD64) || defined(SPARC)
>      return true;
> #else
>      return false;
> #endif
>    }
> 
> Instead, it is better to use a flag which is #defined in the back
> ends, and allow each back end to specify if it supports thread-local
> handshakes.  We have *two* AARCH64 back ends, and only one of them
> supports thread-local handshakes; both of them #define AARCH64.
> 
> #if defined(BLAH) should be reserved for hardware-specific properties,
> not back-end-specific properties.
> 


More information about the hotspot-dev mailing list