RFR (L, tedious again, sorry) 8189610: Reconcile jvm.h and all jvm_md.h between java.base and hotspot
coleen.phillimore at oracle.com
coleen.phillimore at oracle.com
Wed Oct 25 16:49:54 UTC 2017
Summary: removed hotspot version of jvm*h and jni*h files
Mostly used sed to remove prims/jvm.h and move #include "jvm.h" after
precompiled.h, so if you have repetitive stress wrist issues don't click
on most of these files.
There were more issues to resolve, however. The JDK windows jni_md.h
file defined jint as long and the hotspot windows jni_x86.h as int. I
had to choose the jdk version since it's the public version, so there
are changes to the hotspot files for this. Generally I changed the code
to use 'int' rather than 'jint' where the surrounding API didn't insist
on consistently using java types. We should mostly be using C++ types
within hotspot except in interfaces to native/JNI code. There are a
couple of hacks in places where adding multiple jint casts was too painful.
Tested with JPRT and tier2-4 (in progress).
open webrev at http://cr.openjdk.java.net/~coleenp/8189610.01/webrev
bug link https://bugs.openjdk.java.net/browse/JDK-8189610
I have a script to update copyright files on commit.
Thanks to Magnus and ErikJ for the makefile changes.
Thanks,
Coleen
More information about the hotspot-dev
mailing list