[RFR]: 8186578: Zero fails to build on linux-sparc due to sparc-specific code

Mon Sep 4 10:30:20 UTC 2017

On 2017-08-24 18:19, Thomas Stüfe wrote:
> On Thu, Aug 24, 2017 at 3:51 PM, John Paul Adrian Glaubitz <
> glaubitz at physik.fu-berlin.de> wrote:
>
>> On 08/24/2017 03:22 PM, John Paul Adrian Glaubitz wrote:
>>
>>> Do the gtests (especially test_memset_with_concurrent_readers.cpp) run
>>>> through with your patch?
>>>>
>>> I will run the testsuite in a second and report back.
>>>
>> Ok. I have to admit I don't understand how to run the testsuite out of the
>> build tree. It mentions jtreg which I have installed:
>>
>> glaubitz at deb4g:~$ jtreg -version
>> jtreg, version 4.2 src b07
>> Installed in /usr/share/java/jtreg.jar
>> Running on platform version 1.8.0_144 from /usr/lib/jvm/java-8-openjdk-sp
>> arc64/jre.
>> Built with 1.8.0_131 on Tue, 20 Jun 2017 10:54:14 +0200.
>> Copyright (c) 1999, 2016, Oracle and/or its affiliates. All rights
>> reserved.
>> Use is subject to license terms.
>> glaubitz at deb4g:~$
>>
>> But the configure script complains about jtreg missing:
>>
>> checking if jtreg failure handler should be built... configure: error:
>> Cannot enable jtreg failure handler without jtreg.
>> configure exiting with result code 1
>> glaubitz at deb4g:~/openjdk/hs$
>>
>> I also don't fully understand how the testsuite is run as mentioned in
>> [1]. It
>> talks about jtreg and then about jtreg harness which doesn't have clear
>> build
>> instructions [2].
>>
>> Adrian
>>
> Sorry, I should have been more specific. The gtests have nothing to do with
> the jtreg suite, they are a set of native tests using google test.
>
> Just execute (from your build directory):
>   ./hotspot/variant-server/libjvm/gtest/gtestLauncher -jdk:./images/jdk
>
> There is also a way to execute them from the make, but I do not know how.
For the record:

"make run-test-gtest"
or
"make run-test TEST=gtest"

The latter form also allows for a test selection, like this: "make 
run-test TEST=gtest:LogDecorations".

See common/doc/testing.md for more information.

/Magnus

>
> Best Regards, Thomas
>
>
>> [1] http://download.java.net/openjdk/testresults/8/docs/howtoruntests.html
>>> [2] http://openjdk.java.net/jtreg/build.html
>>>
>> --
>>   .''`.  John Paul Adrian Glaubitz
>> : :' :  Debian Developer - glaubitz at debian.org
>> `. `'   Freie Universitaet Berlin - glaubitz at physik.fu-berlin.de
>>    `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913
>>