RFR(XS): 8187280: Remove unused methods from StubQueue

Vladimir Kozlov vladimir.kozlov at oracle.com
Wed Sep 6 20:06:47 UTC 2017


Good

Thanks 
Vladimir

> On Sep 6, 2017, at 10:31 AM, Volker Simonis <volker.simonis at gmail.com> wrote:
> 
> On Wed, Sep 6, 2017 at 6:14 PM, Vladimir Kozlov
> <vladimir.kozlov at oracle.com> wrote:
>> What about stub_code_begin and stub_code_end?
>> 
> 
> You're right! Removed them as well:
> 
> http://cr.openjdk.java.net/~simonis/webrevs/2017/8187280.v1/
> 
> Thanks,
> Volker
> 
>> Thanks
>> Vladimir
>> 
>> Sent from my iPhone
>> 
>>> On Sep 6, 2017, at 7:02 AM, Volker Simonis <volker.simonis at gmail.com> wrote:
>>> 
>>> Hi,
>>> 
>>> can I please get a review and a sponsor for the following trivial change:
>>> 
>>> http://cr.openjdk.java.net/~simonis/webrevs/2017/8187280/
>>> https://bugs.openjdk.java.net/browse/JDK-8187280
>>> 
>>> 
>>> While working on "8166317: InterpreterCodeSize should be computed" I
>>> found that several methods on StubQueue are not used any more in the
>>> current code base. As StubQueue's code is "more subtle than it looks"
>>> (see stubs.cpp) I think it helps to at least remove the unused parts
>>> :)
>>> 
>>> Tested by doing a product/slowdebug build and running the hotspot
>>> regression tests.
>>> 
>>> Thank you and best regards,
>>> Volker
>> 



More information about the hotspot-dev mailing list