RFR (S) 8081323: ConstantPool::_resolved_references is missing in heap dump

coleen.phillimore at oracle.com coleen.phillimore at oracle.com
Fri Sep 22 20:33:44 UTC 2017


Harold pointed out privately that having 
ConstantPool::resolved_references() sometimes return NULL forces the 
callers to check for null for safety, so I added a 
resolved_references_or_null() call for the heap dumper to call instead.

Please review this new version, also small:

open webrev at http://cr.openjdk.java.net/~coleenp/8081323.02/webrev
bug link https://bugs.openjdk.java.net/browse/JDK-8081323

Reran tier1 and heapdump tests.

Thanks,
Coleen

On 9/5/17 12:50 PM, coleen.phillimore at oracle.com wrote:
>
> Thank you, Serguei!
> Coleen
>
> On 9/1/17 6:48 PM, serguei.spitsyn at oracle.com wrote:
>> Hi Coleen,
>>
>> The fix looks good.
>>
>> Thanks,
>> Serguei
>>
>>
>> On 8/31/17 09:02, coleen.phillimore at oracle.com wrote:
>>> Summary: Add resolved_references and init_lock as hidden static 
>>> field in class so root is found.
>>>
>>> Tested manually with YourKit.  See bug for images.   Also ran 
>>> serviceability tests.
>>>
>>> open webrev at http://cr.openjdk.java.net/~coleenp/8081323.01/webrev
>>> bug link https://bugs.openjdk.java.net/browse/JDK-8081323
>>>
>>> Thanks,
>>> Coleen
>>>
>>
>



More information about the hotspot-dev mailing list